Closed adikul30 closed 3 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: adikul30, divyenpatel
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
What this PR does / why we need it:
2839 changed the deprecated
Poll()
toPollUntilContextTimeout()
to
The
true
arg stands for immediate polling. So, the earlier behavior waited for 5 seconds initially before making the call to VC. In the new method, there is no initial wait.In a perf test, this translated to more metadata sync operations lowering the number of other volume operations (create, delete) that CNS can handle. As a result, the number of operations of create volume and delete volume for the test dropped.
Passing immediate = false should make the behavior same as before.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Testing done: Perf test recovered original perf
Special notes for your reviewer:
Release note: