search

kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
288 stars 173 forks source link

RWX Topology automation code fixes and inclusion of multivc disruptive scenarios #2924

Closed sipriyaa closed 2 weeks ago

sipriyaa commented 3 weeks ago

What this PR does / why we need it: RWX code fixes and inclusion of multivc disruptive scenarios

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes # RWX code fixes and inclusion of multivc disruptive scenarios

Testing done: Yes testlogs.txt

sipriya@C02CR8ENMD6M vsphere-csi-driver % golangci-lint run --enable=lll sipriya@C02CR8ENMD6M vsphere-csi-driver % make golangci-lint hack/check-golangci-lint.sh golangci/golangci-lint info checking GitHub for tag 'v1.57.2' golangci/golangci-lint info found version: 1.57.2 for v1.57.2/darwin/amd64 golangci/golangci-lint info installed /Users/sipriya/go/bin/golangci-lint INFO [config_reader] Config search paths: [./ /Users/sipriya/rwx-code-lastset/vsphere-csi-driver /Users/sipriya/rwx-code-lastset /Users/sipriya /Users /] INFO [config_reader] Used config file .golangci.yml INFO [lintersdb] Active 8 linters: [errcheck gosimple govet ineffassign lll misspell staticcheck unused] INFO [loader] Go packages loading at mode 575 (compiled_files|deps|types_sizes|exports_file|files|imports|name) took 11.764211901s INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 338.72197ms INFO [linters_context/goanalysis] analyzers took 59.52501876s with top 10 stages: buildir: 17.70711853s, misspell: 4.134302886s, S1038: 3.016776451s, lll: 2.115088253s, isgenerated: 1.657943822s, printf: 1.62414968s, unused: 1.265618387s, S1039: 1.257782271s, SA1012: 1.196663894s, ctrlflow: 1.161422592s INFO [runner] Issues before processing: 142, after processing: 0 INFO [runner] Processors filtering stat (out/in): invalid_issue: 142/142, skip_dirs: 142/142, exclude-rules: 1/52, cgo: 142/142, path_prettifier: 142/142, identifier_marker: 52/52, filename_unadjuster: 142/142, skip_files: 142/142, autogenerated_exclude: 52/142, exclude: 52/52, nolint: 0/1 INFO [runner] processing took 140.464088ms with stages: autogenerated_exclude: 107.722291ms, nolint: 29.245059ms, identifier_marker: 1.745919ms, path_prettifier: 1.114133ms, skip_dirs: 341.542µs, exclude-rules: 250.511µs, cgo: 17.506µs, invalid_issue: 13.308µs, filename_unadjuster: 7.318µs, max_same_issues: 1.482µs, uniq_by_line: 1.138µs, sort_results: 600ns, fixer: 520ns, diff: 399ns, exclude: 358ns, skip_files: 319ns, source_code: 316ns, path_prefixer: 298ns, max_per_file_from_linter: 296ns, max_from_linter: 293ns, path_shortener: 242ns, severity-rules: 240ns INFO [runner] linters took 11.843283369s with stages: goanalysis_metalinter: 11.702648332s INFO File cache stats: 343 entries of total size 7.4MiB INFO Memory: 240 samples, avg is 602.1MB, max is 2598.0MB INFO Execution took 23.981819355s
sipriya@C02CR8ENMD6M vsphere-csi-driver %

sipriyaa commented 2 weeks ago

/test pull-vsphere-csi-driver-verify-staticcheck

sipriyaa commented 2 weeks ago

/test pull-vsphere-csi-driver-verify-fmt

sipriyaa commented 2 weeks ago

/retest-required

kavyashree-r commented 2 weeks ago

/approve /lgtm

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kavyashree-r, rajguptavm, sipriyaa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[tests/e2e/OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/OWNERS)~~ [kavyashree-r,sipriyaa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment