search

kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
288 stars 173 forks source link

Use optimistic merge for paravirt volumes patch #2928

Closed akutz closed 3 weeks ago

akutz commented 3 weeks ago

What this PR does / why we need it:

This is a cross-port of #2925

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:

$ go test ./pkg/csi/service/wcpguest 
ok      sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/wcpguest  6.628s

Special notes for your reviewer:

Release note:

Use optimistic merge when updating VirtualMachine volumes list to prevent overwriting list with stale data.
k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akutz, divyenpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/release-3.3/OWNERS)~~ [divyenpatel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment