search

kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
288 stars 173 forks source link

WCP test fix #2934

Closed kavyashree-r closed 6 days ago

kavyashree-r commented 2 weeks ago

What this PR does / why we need it: In case of WCP , Updated the code to use SetPolicyQuotaQuota and RemovePolicyQuota instead of createResourceQuota and DeleteResourceQuota And Fixed few test failures in online volume expansion and volume health

Testing done: Yes

Special notes for your reviewer: Refactored WCP code Addded SetPolicyQuotaQuota and RemovePolicyQuota methods

https://gist.github.com/kavyashree-r/c7bd2f96094217b8c8ccb3a48a6d6404
https://gist.github.com/kavyashree-r/01032c8b205d7ff44fbee70f93477472
kavyashree-r commented 2 weeks ago

/ok-to-test

chethanv28 commented 1 week ago

/retest

sipriyaa commented 6 days ago

/approve /lgtm

k8s-ci-robot commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kavyashree-r, sipriyaa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[tests/e2e/OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/OWNERS)~~ [kavyashree-r,sipriyaa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment