Closed vdkotkar closed 1 week ago
Hi @vdkotkar. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
Let's add corresponding MRs in all different repos in the description. This will be easy to for cross-referencing:
Change the description, apart from that, this looks fine.
/approve
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: deepakkinni, vdkotkar, xing-yang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it: We already used "volume.cns.vsphere.vmware.com" and "snapshot.cns.vsphere.vmware.com" as extension service name in vSphere 8.0u3 StoragePolicyQuota and StoragePolicyUsage CRs (even though we were not using extension service). So, to avoid patching older CRs in case of upgrade to vSphere 9.0 version, keeping same extension service name in CR status. Internally storage quota webhook will use appropriate extension service name to send requests for getting resource capacity.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Testing done: Verified that PVC creation is successful with these changes:
storagepolicyquota details:
storagepolicyusage details:
Special notes for your reviewer:
Release note: