Closed nikhilbarge closed 2 months ago
Hi @nikhilbarge. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
PR needs rebase.
Need to fix issue with govmomi, which currently not returning correct value for field AggregatedSnapshotCapacityInMb on Create and Delete Snapshot API calls. however this PR implements workaround for above issue by fetching the same using QueryVolume API call
/approve
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: deepakkinni, nikhilbarge, xing-yang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it: This PR will update cnsvolumeinfo with snapshot details when snapshot is deleted. Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Testing done: Manual testing performed running e2e tests
Special notes for your reviewer:
Release note: