search

kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
293 stars 177 forks source link

[wip] topology code fixes #2953

Open sipriyaa opened 1 month ago

sipriyaa commented 1 month ago

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done: A PR must be marked "[WIP]", if no test result is provided. A WIP PR won't be reviewed, nor merged. The requester can determine a sufficient test, e.g. build for a cosmetic change, E2E test in a predeployed setup, etc. For new features, new tests should be done, in addition to regression tests. If jtest is used to trigger precheckin tests, paste the result after jtest completes and remove [WIP] in the PR subject. The review cycle will start, only after "[WIP]" is removed from the PR subject.

Special notes for your reviewer:

Release note:

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sipriyaa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[tests/e2e/OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/tests/e2e/OWNERS)~~ [sipriyaa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 month ago

@sipriyaa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-vsphere-csi-driver-verify-golangci-lint 641abd38a7bb4a6a5d594d74436af5f45c2a0b94 link true /test pull-vsphere-csi-driver-verify-golangci-lint
pull-vsphere-csi-driver-verify-vet 641abd38a7bb4a6a5d594d74436af5f45c2a0b94 link true /test pull-vsphere-csi-driver-verify-vet
pull-vsphere-csi-driver-verify-staticcheck 641abd38a7bb4a6a5d594d74436af5f45c2a0b94 link true /test pull-vsphere-csi-driver-verify-staticcheck

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).