Closed vdkotkar closed 1 month ago
Hi @vdkotkar. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
/approve
Please rebase.
/approve
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: akankshapanse, deepakkinni, vdkotkar
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it: This PR takes care of following changes:
Take following actions when CnsVolumeInfo CR is updated - Update the VolumeSnapshot StoragePolicyUsage CR in the following ways: i. Update “Used” based on the previous and current CnsVolumeInfo ii. Add annotation “csi.vsphere.missing-snapshot-aggregated-capacity: true” if there is no valid aggregated snapshot size.
Mixed host reconciliation logic related to storage quota feature is moved from CSI layer to CNS layer, hence there is no need to watch on AvailabilityZone CRs. Removed relevant code from syncer.
Added go.mod and go.sum changes generated after running
go mod tidy
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Testing done: Initial StoragePolicyUsage CR for Snapshot:
Manually updated CnsVolumeInfo, increased aggregatedsnapshotsize by 20Mi.
Updated StoragePolicyUsage CR for Snapshot:
Manually updated CnsVolumeInfo, decreased aggregatedsnapshotsize by 5Mi.
Updated StoragePolicyUsage CR for Snapshot:
Manually updated CnsVolumeInfo, changed validaggregatedsnapshotsize flag to false.
Updated StoragePolicyUsage CR for Snapshot:
Special notes for your reviewer:
Release note: