Closed gohilankit closed 1 month ago
/ok-to-test
Do we need a feature gate for creating this CRD from syncer or ok to create it directly?
Do we need a feature gate for creating this CRD from syncer or ok to create it directly?
I will add a feature gate in the next MR pretty soon. Already discussed that with @divyenpatel
/approve
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: adikul30, deepakkinni, gohilankit
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Do we need a feature gate for creating this CRD from syncer or ok to create it directly?
I will add a feature gate in the next MR pretty soon. Already discussed that with @divyenpatel
Addressed this in the MR https://github.com/kubernetes-sigs/vsphere-csi-driver/pull/2971. PTAL @adikul30
What this PR does / why we need it: This PR is a follow-up to #2959 . It creates struct for CnsUnregisterVolume CRD, registers the corresponding controller & adds an empty implementation for it. It also adds the necessary RBAC changes.
The logic for controller will be added in a subsequent MR.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Testing done: Deployed changes in a Supervisor cluster, and observed that the CNS operator components are getting initialized correctly.
Created a CnsUnregisterVolume instance in namespace
playground-ns
with below manifest:Verified from syncer logs that the flow is reaching the
Reconcile
method in the controller.The logic to be added in
Reconcile
method will be added in a subsequent MR.Release note: