search

kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
295 stars 181 forks source link

Update interval to 10min for storage quota periodic sync #3081

Open nikhilbarge opened 1 month ago

nikhilbarge commented 1 month ago

What this PR does / why we need it: Update time interval to 10min and added provision to disable periodic sync for storage quota.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:

Special notes for your reviewer:

Release note:

Update interval to 10min for storage quota periodic sync
k8s-ci-robot commented 1 month ago

Hi @nikhilbarge. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
vdkotkar commented 1 month ago

For now let's go ahead and make default periodic sync interval to 10 min, if we see that it is increasing the resource's consumption and hampering performance, then we will go back to 30 min.

vdkotkar commented 1 month ago

/approve

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nikhilbarge, vdkotkar Once this PR has been reviewed and has the lgtm label, please assign gohilankit for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
akankshapanse commented 1 month ago

/ok-to-test

vdkotkar commented 1 month ago

These changes are being done thorugh PR https://github.com/kubernetes-sigs/vsphere-csi-driver/pull/3086, please close this one.