search

kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
296 stars 179 forks source link

CSI driver logs passowrd in cleartext whith DEBUg loglevel #3089

Open MaxRink opened 2 weeks ago

MaxRink commented 2 weeks ago

/kind bug

What happened: We turned on DEBUG logs for debugging and found the the password used by the CSI driver gets logged in full. 2024-10-24T15:10:04.861Z DEBUG config/config.go:422 vc server my.server config: &{User:myuser Password:mypwd VCenterPort:443 InsecureFlag:true Datacenters:REF TargetvSANFileShareDatastoreURLs: TargetvSANFileShareClusters: MigrationDataStoreURL:}{"TraceId": "ea031f5d-8bf6-47ba-b939-698b31aae0cc"} What you expected to happen: Passwords get redacted in log output

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

divyenpatel commented 2 weeks ago

@MaxRink issue is fixed with this PR - https://github.com/kubernetes-sigs/vsphere-csi-driver/pull/3063