Open kolluria opened 4 weeks ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kolluria Once this PR has been reviewed and has the lgtm label, please assign akankshapanse for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @kolluria. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Testing done: A PR must be marked "[WIP]", if no test result is provided. A WIP PR won't be reviewed, nor merged. The requester can determine a sufficient test, e.g. build for a cosmetic change, E2E test in a predeployed setup, etc. For new features, new tests should be done, in addition to regression tests. If jtest is used to trigger precheckin tests, paste the result after jtest completes and remove [WIP] in the PR subject. The review cycle will start, only after "[WIP]" is removed from the PR subject.
Special notes for your reviewer:
Release note: