kubernetes-sigs / vsphere-csi-driver

vSphere storage Container Storage Interface (CSI) plugin
https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/index.html
Apache License 2.0
295 stars 181 forks source link

add dynamic workload isolation fss enablement for PVCSI #3100

Closed divyenpatel closed 1 week ago

divyenpatel commented 2 weeks ago

What this PR does / why we need it: This PR enables Workload Management Isolation feature in PVCSI upon detecting FSS enablement.

Testing done:

Log message when FSS is enabled in internal-feature-states.csi.vsphere.vmware.com and later enabled in csi-feature-states configmap

{"level":"info","time":"2024-11-09T00:19:08.480087802Z","caller":"k8sorchestrator/k8sorchestrator.go:1203","msg":"workload-domain-isolation feature state is set to false in csi-feature-states ConfigMap","TraceId":"0bb12f08-a793-4f77-8f5a-8e923d03b758","TraceId":"1b68da63-1607-4362-bd33-5db7f0b0b334"} {"level":"info","time":"2024-11-09T00:19:08.512622933Z","caller":"k8sorchestrator/k8sorchestrator.go:769","msg":"Observed Configmap update for \"csi-feature-states\" in namespace \"vmware-system-csi\""} {"level":"info","time":"2024-11-09T00:19:08.516643054Z","caller":"k8sorchestrator/k8sorchestrator.go:789","msg":"Detected Enablement of FSS: \"workload-domain-isolation\". Restarting Container."}

Special notes for your reviewer:

Release note:

add dynamic workload isolation fss enablement for PVCSI
shalini-b commented 1 week ago

/approve /lgtm

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, shalini-b

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/OWNERS)~~ [divyenpatel,shalini-b] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
shalini-b commented 1 week ago

/ok-to-test