search

kubernetes-sigs / wg-device-management

Prototypes and experiments for WG Device Management.
Apache License 2.0
7 stars 7 forks source link

DRA API evolution #14

Closed pohly closed 3 months ago

pohly commented 4 months ago

This creates a "dra-evolution" directory with an alternative to the "k8srm-prototype". Whereas"k8srm-prototype" started with a blank slate, "dra-evolution" started with the 1.30 API and got updated to make it more like "k8srm-prototype".

It includes respectively supersedes the following incremental KEP updates:

The top-level README.md has a comparison table with a rationale why certain changes were made (or not made).

It's now possible to do go test ./testdata, which checks that the YAML files and the embedded CEL expressions match the types and CEL syntax.

cmd and pkg/gen have not been updated yet. The pkg/api is complete and now also includes the pod spec changes. But please don't review yet. @pohly and @klueska are still in the process of converting the YAML testdata files, which may lead to changes in the API.

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/wg-device-management/blob/main/OWNERS)~~ [pohly] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pohly commented 4 months ago

I've pushed an update which:

I have not squashed because I want to give others a chance to catch up.

I did not get to updating the quota_types.go today. See https://github.com/kubernetes-sigs/wg-device-management/pull/14#discussion_r1613095446 for a list of suggestions and questions around that. I intend to add those changes to this PR because they are needed for 1.31.

johnbelamaric commented 3 months ago

/lgtm