search

kubernetes-sigs / wg-device-management

Prototypes and experiments for WG Device Management.
Apache License 2.0
4 stars 5 forks source link

Paritionable model with grouped resources #29

Closed johnbelamaric closed 2 weeks ago

johnbelamaric commented 2 weeks ago

This is another alternative to the partitionable model.

The PR is a delta on top of #27.

Rather than flattening the individual physical GPU named resources into a single array, this is closer to Kevin's original, and keeps each physical GPU's shared resources in a separate struct. The individual devices then consume from those structs, by name. It is also possible for a device to consume from multiple shared resource groups, though that is not shown in the example.

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/wg-device-management/blob/main/OWNERS)~~ [johnbelamaric] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
thockin commented 2 weeks ago

Since this is "what's in the KEP" I think we should merge it and rebase all the options on it, so they appear as diffs.

/lgtm

thockin commented 2 weeks ago

Shoot, I screwed up and approved the wrong one! I meant to LGTM #27 !!!