search

kubernetes-sigs / wg-policy-prototypes

A place for policy work group related proposals and prototypes.
Apache License 2.0
64 stars 39 forks source link

[FIX]: adds and fixes namespaces for kube-bench job to be specified by user #102

Closed mritunjaysharma394 closed 2 years ago

mritunjaysharma394 commented 2 years ago

This PR fixes #93

It adds --namespace option for user to specify in which the kube-bench job must be run.

cc @realshuting @JimBugwadia

Signed-off-by: Mritunjay Sharma mritunjaysharma394@gmail.com

k8s-ci-robot commented 2 years ago

@realshuting: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/wg-policy-prototypes/pull/102#pullrequestreview-865695893): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mritunjaysharma394 commented 2 years ago

/assign @JimBugwadia

JimBugwadia commented 2 years ago

/lgtm /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JimBugwadia, mritunjaysharma394, realshuting

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/wg-policy-prototypes/blob/master/OWNERS)~~ [JimBugwadia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment