search

kubernetes-sigs / wg-policy-prototypes

A place for policy work group related proposals and prototypes.
Apache License 2.0
64 stars 39 forks source link

Remove uniqueItems from statusFilter #129

Closed anusha94 closed 8 months ago

anusha94 commented 8 months ago

Fixes #128

anusha94 commented 8 months ago

Looks like an older version (v0.9.0) of controller-gen was used, can you please try with the latest or v0.12.1 (the one previously used)?

Yea I changed back to what was being used, and removed other go.mod related changes as well.

Tested by installing this CRD on a kind cluster, and it works fine.

JimBugwadia commented 8 months ago

/lgtm /approve

k8s-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anusha94, JimBugwadia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/wg-policy-prototypes/blob/master/OWNERS)~~ [JimBugwadia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment