search

kubernetes-sigs / wg-policy-prototypes

A place for policy work group related proposals and prototypes.
Apache License 2.0
64 stars 39 forks source link

fix: should NOT use slice of pointers in API types #133

Closed erikgb closed 7 months ago

erikgb commented 7 months ago

I am trying to generate applyconfigurations of the API types in this project, and it seems like the generator does not support slices of pointers. And I don't understand why we need to have pointers in the slices and not just simple structs.

This PR changes all slices of pointers to simple slices of structs. This is a breaking change for users of the Go API, with a simple fix, but NOT breaking on the Kubernetes API level.

This issue was raised and discussed on Slack.

/cc @JimBugwadia

JimBugwadia commented 7 months ago

/lgtm /approve

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb, fjogeleit, JimBugwadia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/wg-policy-prototypes/blob/master/OWNERS)~~ [JimBugwadia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment