kubernetes-sigs / wg-policy-prototypes

A place for policy work group related proposals and prototypes.
Apache License 2.0
64 stars 39 forks source link

fix: update the oscal-samples demo to use the latest trestle #137

Closed Ma1h01 closed 2 weeks ago

Ma1h01 commented 3 months ago

Description

  1. Resolved https://github.com/oscal-compass/compliance-trestle-demos/issues/41
  2. Updated the Makefile to install the latest trestle version and activate the virtual environment for make help
  3. Fixed importing the deprecated module in k8s-to-oscal.py
  4. Created a helper function to indicate whether the YAML file is valid in k8s-to-oscal.py, and only parse those are valid.
linux-foundation-easycla[bot] commented 3 months ago

CLA Signed


The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 3 months ago

Welcome @Ma1h01!

It looks like this is your first PR to kubernetes-sigs/wg-policy-prototypes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/wg-policy-prototypes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-triage-robot commented 2 weeks ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

JimBugwadia commented 2 weeks ago

/remove-lifecycle stale

JimBugwadia commented 2 weeks ago

/lgtm /approve

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JimBugwadia, Ma1h01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/wg-policy-prototypes/blob/master/OWNERS)~~ [JimBugwadia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment