search

kubernetes-sigs / wg-serving

WG Serving
https://github.com/kubernetes/community/tree/master/wg-serving
Apache License 2.0
13 stars 12 forks source link

add HorizontalPodAutoscaler stub to catalog #15

Closed nojnhuh closed 2 weeks ago

nojnhuh commented 1 month ago

This PR adds a HorizontalPodAutoscaler to each of the deployment permutations currently specified by the serving-catalog. It triggers based on a (currently hypothetical) token-latency-ms custom metric.

nojnhuh commented 1 month ago

/cc @jackfrancis @raywainman

nojnhuh commented 1 month ago

adding "stub": /retitle add HorizontalPodAutoscaler stub to catalog

raywainman commented 1 month ago

/lgtm

/assign Bslabe123

k8s-ci-robot commented 1 month ago

@raywainman: GitHub didn't allow me to assign the following users: Bslabe123.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-sigs/wg-serving/pull/15#issuecomment-2402835556): >/lgtm > >/assign Bslabe123 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
raywainman commented 1 month ago

/assign @Bslabe123

k8s-ci-robot commented 1 month ago

@raywainman: GitHub didn't allow me to assign the following users: Bslabe123.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-sigs/wg-serving/pull/15#issuecomment-2402837459): >/assign @Bslabe123 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
Bslabe123 commented 1 month ago

/assign @Bslabe123

Bslabe123 commented 1 month ago

/lgtm

k8s-ci-robot commented 1 month ago

@Bslabe123: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/wg-serving/pull/15#issuecomment-2402909273): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jackfrancis commented 2 weeks ago

@raywainman @skonto @jjk-g is this ready for merge?

jjk-g commented 2 weeks ago

/lgtm /approve

thanks for the contribution!

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jjk-g, nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[serving-catalog/OWNERS](https://github.com/kubernetes-sigs/wg-serving/blob/main/serving-catalog/OWNERS)~~ [jjk-g] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment