search

kubernetes-sigs / wg-serving

WG Serving
https://github.com/kubernetes/community/tree/master/wg-serving
Apache License 2.0
13 stars 12 forks source link

[Serving Catalog] Update vllm base deployment label #25

Closed jjk-g closed 3 weeks ago

jjk-g commented 3 weeks ago

Deployment label should be app and not name.

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jjk-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[serving-catalog/OWNERS](https://github.com/kubernetes-sigs/wg-serving/blob/main/serving-catalog/OWNERS)~~ [jjk-g] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ahg-g commented 3 weeks ago

/lgtm