search

kubernetes-sigs / windows-gmsa

External components to support Windows GMSA in Kubernetes
Apache License 2.0
30 stars 57 forks source link

nodeselector in values.yaml of Helm chart is incorrect #129

Closed aiyengar2 closed 1 year ago

aiyengar2 commented 1 year ago

nodeselector should be nodeSelector:

https://github.com/kubernetes-sigs/windows-gmsa/blob/7f48de91473ce9883b88f4252b2e074032b0a5df/charts/gmsa/values.yaml#L35

https://github.com/kubernetes-sigs/windows-gmsa/blob/7f48de91473ce9883b88f4252b2e074032b0a5df/charts/gmsa/templates/deployment.yaml#L31-L33

aiyengar2 commented 1 year ago

Fixed in https://github.com/kubernetes-sigs/windows-gmsa/pull/128

marosset commented 1 year ago

/closed Fixed