kubernetes-sigs / windows-testing

Containers, scripts and documentation for running Kubernetes tests with Windows nodes
Apache License 2.0
40 stars 55 forks source link

Updating templates used by az capi to use external cloud provider #382

Closed marosset closed 1 year ago

marosset commented 1 year ago

Updating run-capz-e2e.sh to deploy clusters with an out of tree cloud provider Fixes #367 /sig windows

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/windows-testing/blob/master/OWNERS)~~ [marosset] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
marosset commented 1 year ago

/hold for PR job and also to make sure all the jobs in test-infra are cloning the cloud-provider-azure repo

marosset commented 1 year ago

Looks like i need to set REGISTRY. Let me see what all the CAPZ jobs set this to

marosset commented 1 year ago

/test pull-e2e-capz-windows-2022-extension

marosset commented 1 year ago

/test pull-e2e-capz-windows-2022-extension

jsturtevant commented 1 year ago

The CMM is up and running, interestingly our job is missing the cluster logs. Not sure why that didn't run

kube-system       cloud-node-manager-c875b                                       1/1     Running             0          11s     10.0.0.4         capz-conf-1rs02n-control-plane-747vt   <none>           <none>
kube-system       cloud-node-manager-windows-fdbnl                               0/1     ContainerCreating   0          11s     10.1.0.5         capz-conf-c5mqd                        <none>           <none>
kube-system       cloud-node-manager-windows-tfcf8
jsturtevant commented 1 year ago

/hold /lgtm

marosset commented 1 year ago

/test pull-e2e-capz-windows-2022-extension

jsturtevant commented 1 year ago

@marosset I am still not seeing logs 🤔 https://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_windows-testing/382/pull-e2e-capz-windows-2022-extension/1671933255319818240/artifacts/

marosset commented 1 year ago

we have logs now! https://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_windows-testing/382/pull-e2e-capz-windows-2022-extension/1672010083464122368/

marosset commented 1 year ago

/assign @jackfrancis for review of ci-build-azure-ccm.sh usage

marosset commented 1 year ago

let's wait until after the v1.28 release to merge this cc @jsturtevant

marosset commented 1 year ago

/test required

k8s-ci-robot commented 1 year ago

@marosset: The specified target(s) for /test were not found. The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/kubernetes-sigs/windows-testing/pull/382#issuecomment-1696364505): >/test required Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
marosset commented 1 year ago

/test all

jsturtevant commented 1 year ago

/lgtm

feel free to release the hold when the tests complete!

marosset commented 1 year ago

/hold cancel