search

kubernetes-sigs / windows-testing

Containers, scripts and documentation for running Kubernetes tests with Windows nodes
Apache License 2.0
40 stars 55 forks source link

Adding logging into replace-containerd.ps1 #395

Closed marosset closed 1 year ago

marosset commented 1 year ago

Adding extra logging in replace-containerd.ps1 to see if any containerd files are locked during upgrade process

/hold

marosset commented 1 year ago

/test pull-e2e-capz-windows-2022-extension

marosset commented 1 year ago

/test pull-e2e-capz-windows-2022-extension

jsturtevant commented 1 year ago

/test pull-e2e-capz-windows-2022-extension

marosset commented 1 year ago

/test pull-e2e-capz-windows-2022-extension

marosset commented 1 year ago

I pulled in https://github.com/kubernetes-sigs/windows-testing/pull/396 which should fix the lint go issues

marosset commented 1 year ago

/hold cancel we should be able to merge this. I will open another PR that uses the latest images so we can trigger a few times and try and catch a repo where containerd isn't getting updated properly @jsturtevant fyi

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/windows-testing/blob/master/OWNERS)~~ [jsturtevant,marosset] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jsturtevant commented 1 year ago

/lgtm