search

kubernetes-sigs / windows-testing

Containers, scripts and documentation for running Kubernetes tests with Windows nodes
Apache License 2.0
40 stars 55 forks source link

Disable transfer service until stabilizes in containerd #421

Closed jsturtevant closed 8 months ago

jsturtevant commented 8 months ago

This will let us continue to run the containerd nightly job

There have been several bug fixes since https://github.com/containerd/containerd/pull/9432 merged but still have a few more issues like https://github.com/containerd/containerd/pull/9717.

Disabling so we can still get nightly signal on containerd 2.0 since we only use ctr for pre-pulling images and transfer service isn't enabled in CRI yet.

k8s-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/windows-testing/blob/master/OWNERS)~~ [jsturtevant] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jsturtevant commented 8 months ago

/assign @aravindhp

marosset commented 8 months ago

This PR may have caused some provisioning failures in our 1.26 clusters - https://testgrid.k8s.io/sig-windows-signal#capz-windows-containerd-1.26 I'll take a deeper look

jsturtevant commented 8 months ago

This PR may have caused some provisioning failures in our 1.26 clusters - https://testgrid.k8s.io/sig-windows-signal#capz-windows-containerd-1.26 I'll take a deeper look

This is likely due the fact that containerd 1.6 doesn't have this flag. Discussed at sig-windows and bumping this to containerd 1.7 for the remaining 2 weeks of support is likely the best course of action