Closed jsturtevant closed 5 months ago
cc @mboersma @dtzar
fyi @ritikaguptams
/assign @marosset
Going to try this out now!
@jsturtevant - can you add the info about having the MI pre-created to https://github.com/kubernetes-sigs/windows-testing/blob/master/capz/readme.md?
The committers listed above are authorized under a signed CLA.
I got a cluster setup using these updates!
let's just update the README then this lgtm!
/test pull-e2e-capz-windows-2022-extension
/cc @bingbing8
@jsturtevant: GitHub didn't allow me to request PR reviews from the following users: bingbing8.
Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jsturtevant, marosset
The full list of commands accepted by this bot can be found here.
The pull request process is described here
The removes the need for Service Principals in the cluster creation process. It uses managed identities on the management cluster and workload clusters instead.
When running locally you can log into the azure CLI via interactive prompt which means the there are no Service Principals needed to run the e2e tests. A service principal is still used for the Azure CLI in CI since this script runs in the PROW instance and doesn't have access to the Azure Managed Identity infrastructure.
This removes the dependency on az capi extension due to https://github.com/Azure/azure-capi-cli-extension/issues/263. This brough the required steps into the scripts here which will make it easier to maintain and debug.
It does assume a cloud-provider-identity pre-created with
/cc @marosset