search

kubernetes-sigs / windows-testing

Containers, scripts and documentation for running Kubernetes tests with Windows nodes
Apache License 2.0
40 stars 54 forks source link

Use 2019 as default #434

Closed jsturtevant closed 3 months ago

jsturtevant commented 3 months ago

In https://github.com/kubernetes-sigs/windows-testing/pull/430/files I bumped the default to 2019 and this is causing conflicts across tests https://github.com/kubernetes/kubernetes/issues/125187#issuecomment-2137858270

While we resolve the issue switching back to the default

marosset commented 3 months ago

/lgtm /approve

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/windows-testing/blob/master/OWNERS)~~ [jsturtevant,marosset] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment