kubernetes-sigs / windows-testing

Containers, scripts and documentation for running Kubernetes tests with Windows nodes
Apache License 2.0
40 stars 55 forks source link

Set registry keys to write process dumps to c:\localdumps #438

Closed marosset closed 4 months ago

marosset commented 4 months ago

This PR adds a new kubeadm action that sets some registries to instruct Windows to write dump for process crashes to c:\localdumps so they can be collected by our log collection scripts.

This was done in the capz templates (https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/aa536cccba7657c4f924e5c5ecc5fca9694c800f/templates/test/ci/cluster-template-prow.yaml#L304-L316) and I could have sworn it was done here to...

/assign @jsturtevant

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/windows-testing/blob/master/OWNERS)~~ [marosset] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jsturtevant commented 4 months ago

/lgtm /hold for ci

marosset commented 4 months ago

/hold cancel