Closed claudiubelu closed 2 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: claudiubelu
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Output with the old flags:
kubeadm config images list --v=1 --kubernetes-version=stable-1 I0617 04:52:25.082414 4884 kubelet.go:195] the value of KubeletConfiguration.cgroupDriver is empty; setting it to "systemd"
I0617 04:52:25.562987 4884 version.go:261] remote version is much newer: v1.30.2; falling back to: stable-1.27 I0617 04:52:25.922895 4884 images.go:80] WARNING: could not find officially supported version of etcd for Kubernetes v1.27.15, falling back to the nearest etcd version (3.5.14-0)
registry.k8s.io/kube-apiserver:v1.27.15
registry.k8s.io/kube-controller-manager:v1.27.15
registry.k8s.io/kube-scheduler:v1.27.15
registry.k8s.io/kube-proxy:v1.27.15
registry.k8s.io/coredns/coredns:v1.11.1
registry.k8s.io/pause:3.10
registry.k8s.io/etcd:3.5.14-0
Output with the new flags:
kubeadm config images list --v=1 --kubernetes-version=stable-1
I0617 05:30:56.549257 2952 kubelet.go:195] the value of KubeletConfiguration.cgroupDriver is empty; setting it to "systemd"
registry.k8s.io/kube-apiserver:v1.30.2
registry.k8s.io/kube-controller-manager:v1.30.2
registry.k8s.io/kube-scheduler:v1.30.2
registry.k8s.io/kube-proxy:v1.30.2
registry.k8s.io/coredns/coredns:v1.11.1
registry.k8s.io/pause:3.10
registry.k8s.io/etcd:3.5.14-0
/lgtm
The unittest
cmdTestCmdConfigImagesList/valid:_latest_stable_Kubernetes_version_should_not_throw_the_warning_that_a_supported_etcd_version_cannot_be_found
currently fails because the commandkubeadm config images list --v=1 --kubernetes-version=stable-1
outputs the warning"WARNING: could not find officially supported version of etcd for Kubernetes v1.27.15, falling back to the nearest etcd version (3.5.14-0)"
, and the test explicitly checks against this specific type of warning.This seems to happen when the build flags used when building kubeadm are older than expected. Building with new flags solves this issue.