search

kubernetes-sigs / windows-testing

Containers, scripts and documentation for running Kubernetes tests with Windows nodes
Apache License 2.0
40 stars 54 forks source link

Use calculated template and save it for debugging #441

Closed jsturtevant closed 2 months ago

jsturtevant commented 2 months ago

After #430, the template was hard coded instead of using the calculated value. We also were not copying the file to the logs for debugging purposes.

jsturtevant commented 2 months ago

This fixes the failing GMSA tests on https://testgrid.k8s.io/sig-windows-master-release#capz-windows-master-serial-slow

jsturtevant commented 2 months ago

/test ls

k8s-ci-robot commented 2 months ago

@jsturtevant: The specified target(s) for /test were not found. The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/kubernetes-sigs/windows-testing/pull/441#issuecomment-2177266963): >/test ls > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jsturtevant commented 2 months ago

/test pull-e2e-capz-windows-2022-extension-gmsa

jsturtevant commented 2 months ago

/test pull-e2e-capz-windows-2022-extension

jsturtevant commented 2 months ago

looks like it might need the fix from https://github.com/kubernetes-sigs/windows-testing/pull/439/commits/b55c9714759aa4f7320496ba9ffe34d5f10cc945, not sure why sometimes it passes

jsturtevant commented 2 months ago

/test pull-e2e-capz-windows-2022-extension-gmsa

jsturtevant commented 2 months ago

docker hub was down yesterday when I ran these tests

/retest

jsturtevant commented 2 months ago

/assign @marosset @aravindhp

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/windows-testing/blob/master/OWNERS)~~ [jsturtevant,marosset] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment