search

kubernetes-sigs / windows-testing

Containers, scripts and documentation for running Kubernetes tests with Windows nodes
Apache License 2.0
40 stars 55 forks source link

Remove storage secret from docs #443

Closed jsturtevant closed 3 months ago

jsturtevant commented 3 months ago

As part of the removal of secrets, we need to remove the secrets to the storage accounts too.

This updates the docs with the details.

/hold dependent on changes in capz https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/4939

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/windows-testing/blob/master/OWNERS)~~ [jsturtevant,marosset] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jsturtevant commented 3 months ago

requires https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/4980

jsturtevant commented 3 months ago

/test pull-e2e-capz-windows-2022-extension

jsturtevant commented 3 months ago

This is now in capz main

/hold cancel

marosset commented 3 months ago

/lgtm