kubernetes-sigs / windows-testing

Containers, scripts and documentation for running Kubernetes tests with Windows nodes
Apache License 2.0
40 stars 54 forks source link

Wire up kubelet credential provider properly in capz templates #446

Open jsturtevant opened 1 month ago

jsturtevant commented 1 month ago

This will not be in the community sub, we will move this to a private registry in the private sub and use kubelet credential provider to access it. we need to wire this in to our templates but the credential binaries are already there https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/4679#issuecomment-2225938449

_Originally posted by @jsturtevant in https://github.com/kubernetes-sigs/windows-testing/pull/444#discussion_r1676492724_

jsturtevant commented 1 month ago

/assign @ritikaguptams

k8s-ci-robot commented 1 month ago

@jsturtevant: GitHub didn't allow me to assign the following users: ritikaguptams.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-sigs/windows-testing/issues/446#issuecomment-2226403575): >/assign @ritikaguptams Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jsturtevant commented 1 month ago

for more info https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/4679#issuecomment-2225938449

ritikaguptams commented 4 weeks ago

/assign @ritikaguptams