search

kubernetes-sigs / windows-testing

Containers, scripts and documentation for running Kubernetes tests with Windows nodes
Apache License 2.0
40 stars 54 forks source link

Parse prow creds when token file not present #448

Closed jsturtevant closed 1 month ago

jsturtevant commented 1 month ago

In #447, I didn't take into account that this script is used across various versions of CAPZ. This adds a check if the token file is present then we will not parse the prow cred secret

jsturtevant commented 1 month ago

/hold for the tests

nawazkh commented 1 month ago

/lgtm

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/windows-testing/blob/master/OWNERS)~~ [jsturtevant,marosset] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jsturtevant commented 1 month ago

/hold cancel

jsturtevant commented 1 month ago

/test ls