search

kubernetes-sigs / windows-testing

Containers, scripts and documentation for running Kubernetes tests with Windows nodes
Apache License 2.0
40 stars 54 forks source link

Update azure sdk for golang #450

Closed jsturtevant closed 1 month ago

jsturtevant commented 1 month ago

After switching to the Workload identity the old SDK didn't support the credentials.

This updates the SDK to use the latest version. The DefaultAzureCredential will work with both ENV variables and workload identity: https://github.com/Azure/azure-sdk-for-go/tree/sdk/azidentity/v1.7.0/sdk/azidentity#defaultazurecredential

k8s-ci-robot commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/windows-testing/blob/master/OWNERS)~~ [jsturtevant] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jsturtevant commented 1 month ago

/test ls

k8s-ci-robot commented 1 month ago

@jsturtevant: The specified target(s) for /test were not found. The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/kubernetes-sigs/windows-testing/pull/450#issuecomment-2229113193): >/test ls > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jsturtevant commented 1 month ago

/test pull-e2e-capz-windows-2022-extension-gmsa

jsturtevant commented 1 month ago

/test pull-e2e-capz-windows-2022-extension-gmsa

jsturtevant commented 1 month ago

/test pull-e2e-capz-windows-2022-extension-gmsa

jsturtevant commented 1 month ago

Authentication is working but goofed up the print statement function

jsturtevant commented 1 month ago

/test pull-e2e-capz-windows-2022-extension-gmsa

jsturtevant commented 1 month ago

/test pull-e2e-capz-windows-2022-extension-gmsa /hold for test

jsturtevant commented 1 month ago

/assign @marosset @ritikaguptams

k8s-ci-robot commented 1 month ago

@jsturtevant: GitHub didn't allow me to assign the following users: ritikaguptams.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-sigs/windows-testing/pull/450#issuecomment-2231924478): >/assign @marosset @ritikaguptams Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jsturtevant commented 1 month ago

capacity error, we are hitting it often going to drop westeurope in separate PR /test pull-e2e-capz-windows-2022-extension-gmsa

jsturtevant commented 1 month ago

452

/test pull-e2e-capz-windows-2022-extension-gmsa

jsturtevant commented 1 month ago

westeurope three times in a row?!

/test pull-e2e-capz-windows-2022-extension-gmsa

jsturtevant commented 1 month ago

/hold cancel

marosset commented 1 month ago

/lgtm