search

kubernetes-sigs / windows-testing

Containers, scripts and documentation for running Kubernetes tests with Windows nodes
Apache License 2.0
40 stars 54 forks source link

Must parse values before loading cli #451

Closed jsturtevant closed 1 month ago

jsturtevant commented 1 month ago

https://github.com/kubernetes-sigs/windows-testing/pull/448 wasn't quiet right because we must do this before we "ensure azure cli" or we won't have the required envs

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/windows-testing/blob/master/OWNERS)~~ [jsturtevant,marosset] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment