search

kubernetes-sigs / windows-testing

Containers, scripts and documentation for running Kubernetes tests with Windows nodes
Apache License 2.0
40 stars 54 forks source link

Use federated token to sign-in on new sub #461

Closed jsturtevant closed 1 month ago

jsturtevant commented 1 month ago

/sig windows Federated Id's are the only way to log in with the new sub. This follows changes in capz: https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/4939

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/windows-testing/blob/master/OWNERS)~~ [jsturtevant] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
marosset commented 1 month ago

I'm a little concerned about being able to run the script locally after these changes but it looks like as long as someone as az cli installed that shouldn't be an issue.

/lgtm