kubernetes-sigs / work-api

Kubernetes Work API
Apache License 2.0
54 stars 21 forks source link

Add link to the main SIG Multicluster page. #1

Closed shrinandj closed 3 years ago

shrinandj commented 3 years ago

This is particularly useful for reaching the weekly meeting Zoom link, etc.

k8s-ci-robot commented 3 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 3 years ago

Welcome @shrinandj!

It looks like this is your first PR to kubernetes-sigs/work-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/work-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

RainbowMango commented 3 years ago

commit missing GitHub user

You are using shrinand_javadekar@intuit.com in your commit, have you added the email to your GitHub account email settings? Also, you should sign the CLA with the same email or just with your GitHub account.

shrinandj commented 3 years ago

Thanks. I added the work email address to the github account and that seems to have done the trick.

I'll wait for this PR to be reviewed.

pmorie commented 3 years ago

/approve /lgtm

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmorie, shrinandj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/work-api/blob/master/OWNERS)~~ [pmorie] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment