search

kubernetes-sigs / work-api

Kubernetes Work API
Apache License 2.0
54 stars 21 forks source link

Update dependencies to latest stable versions and Go version to 1.17 #19

Closed mikeshng closed 2 years ago

mikeshng commented 2 years ago

Signed-off-by: Mike Ng ming@redhat.com

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mikeshng To complete the pull request process, please assign qiujian16 after the PR has been reviewed. You can assign the PR to them by writing /assign @qiujian16 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/work-api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mikeshng commented 2 years ago

Trying to resolve the lint issue in the other PR https://github.com/kubernetes-sigs/work-api/pull/18 but it doesn't look like updating the dependencies help.

RainbowMango commented 2 years ago

Let me see if I can help with the lint issue.

mikeshng commented 2 years ago

Let me see if I can help with the lint issue.

Thanks @RainbowMango I tried on my local fork with this change it should work https://github.com/kubernetes-sigs/work-api/pull/20 but I am not sure why it's not trigger the GitHub action job now in the PR.