kubernetes-sigs / work-api

Kubernetes Work API
Apache License 2.0
54 stars 21 forks source link

Fix hack/update-codegen.sh failed to generates the code in right place #31

Closed RainbowMango closed 3 months ago

RainbowMango commented 3 months ago

When I try to fix issue #30, I found the hack/update-codegen.sh actually not working.

It will generates the files at repo/sigs.k8s.io/... instead of repo/pkg/....

-bash-5.0# hack/update-codegen.sh 
Generating deepcopy funcs
Generating clientset at sigs.k8s.io/work-api/pkg/client/clientset
Generating listers at sigs.k8s.io/work-api/pkg/client/listers
Generating informers at sigs.k8s.io/work-api/pkg/client/informers
Generating register at sigs.k8s.io/work-api/pkg/apis/v1alpha1
-bash-5.0# git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
    sigs.k8s.io/

nothing added to commit but untracked files present (use "git add" to track)
k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/work-api/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
RainbowMango commented 3 months ago

/hold wait for #32

RainbowMango commented 3 months ago

/hold cancel cc @qiujian16 @mikeshng

qiujian16 commented 3 months ago

/lgtm