qiujian16
commented
3 years ago /assign @pmorie
Closed qiujian16 closed 3 years ago
qiujian16
commented
3 years ago /assign @pmorie
RainbowMango
commented
3 years ago @qiujian16 @pmorie Just posted two suggestions about the API, I would like to hear your views.
pmorie
commented
3 years ago @RainbowMango I think my preference would be to merge this PR without a lot of mutation, since it is capturing what previously was in the google doc, and make changes in follow-on PRs. I think it is important to get the work done so far reflected in the main branch (note to self, we should rename this in keeping with the use of inclusive language) to demonstrate the work done so far. How does that sound?
RainbowMango
commented
3 years ago That makes sense. We can iterate it later. /lgtm /approve
k8s-ci-robot
commented
3 years ago [APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: qiujian16, RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Welcome @qiujian16!
It looks like this is your first PR to kubernetes-sigs/work-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/work-api has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley: