search

kubernetes-sigs / work-api

Kubernetes Work API
Apache License 2.0
54 stars 21 forks source link

Add work apply controller #7

Closed qiujian16 closed 3 years ago

qiujian16 commented 3 years ago

/hold

still need to add ut at least

qiujian16 commented 3 years ago

/assign @RainbowMango /assign @pmorie

RainbowMango commented 3 years ago

Good job!!! @qiujian16 I'll look at it ASAP.

RainbowMango commented 3 years ago

/lgtm Left approval to @pmorie .

RainbowMango commented 3 years ago

/approve Let's move forward faster and iterate it later if there are any comments/issues.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/work-api/blob/master/OWNERS)~~ [RainbowMango] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment