search

kubernetes-up-and-running / kuard

Demo app for Kubernetes Up and Running book
Apache License 2.0
1.56k stars 535 forks source link

Chapter 12 Deployments typo for template annotations #13

Closed michaelsrichter closed 5 years ago

michaelsrichter commented 6 years ago

page 126 - template doesn't have an annotations object (that is what the example seems to be suggesting) - annotations need to be created inside the metadata object of template

epequeno commented 5 years ago

currently 

spec:
  ...
  template:
    annotations:
      kubernetes.io/change-cause: "Update nginx to 1.9.10"
...

should be

spec:
  ...
  template:
    metadata:
      annotations:
        kubernetes.io/change-cause: "Update nginx to 1.9.10"
...
jbeda commented 5 years ago

This should be fixed in the latest ebook version of it and we'll make sure we have it fixed in any future editions to the book. Thanks!