kubernetes / apiserver

Library for writing a Kubernetes-style API server.
Apache License 2.0
647 stars 400 forks source link

Dependency change for square/go-jose v2 #105

Closed lachieggg closed 7 months ago

lachieggg commented 7 months ago

Dependency version change for square/go-jose v2

Modify go mod to fix dependencies on go-jose v2 which has a CVE and is archived. It is recommended to use https://github.com/go-jose/go-jose now.

Fixes security advisory BDSA-2023-3257

linux-foundation-easycla[bot] commented 7 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 7 months ago

Welcome @lachieggg!

It looks like this is your first PR to kubernetes/apiserver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/apiserver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lachieggg Once this PR has been reviewed and has the lgtm label, please assign liggitt for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/apiserver/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nilekhc commented 7 months ago

@lachieggg Could you please provide a link for Fixes security advisory BDSA-2023-3257

Also please open an issue in kubernetes/kubernetes repo.

/close

k8s-ci-robot commented 7 months ago

@nilekhc: Closed this PR.

In response to [this](https://github.com/kubernetes/apiserver/pull/105#issuecomment-1939207707): >@lachieggg Could you please provide a link for `Fixes security advisory BDSA-2023-3257` > >Also please open an issue in kubernetes/kubernetes repo. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
enj commented 7 months ago

From the read me:

image