search

kubernetes / apiserver

Library for writing a Kubernetes-style API server.
Apache License 2.0
647 stars 400 forks source link

Error is returned when TableConverter is nil #74

Closed jroper closed 2 years ago

jroper commented 2 years ago

According to the documentation on the Store.TableConverter field, it can be nil:

https://github.com/kubernetes/apiserver/blob/9144ea1240a23e7321ac9c9ea76d893e686ad8e1/pkg/registry/generic/registry/store.go#L202-L204

And, where it's used, a nil check is done and the behavior matches that comment:

https://github.com/kubernetes/apiserver/blob/9144ea1240a23e7321ac9c9ea76d893e686ad8e1/pkg/registry/generic/registry/store.go#L1466-L1471

However, when it is nil, validation in the CompleteWithOptions method returns an error, contrary to the docs and the behavior:

https://github.com/kubernetes/apiserver/blob/9144ea1240a23e7321ac9c9ea76d893e686ad8e1/pkg/registry/generic/registry/store.go#L1303-L1305

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closing this issue.

In response to [this](https://github.com/kubernetes/apiserver/issues/74#issuecomment-1099743516): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.