search

kubernetes / apiserver

Library for writing a Kubernetes-style API server.
Apache License 2.0
654 stars 406 forks source link

Tag v0.28.1 - Issue #97

Closed migounette closed 7 months ago

migounette commented 1 year ago

I was trying to understand the reason of this... and during my investigation I got this (see the pic) This commit does not belong.... is it normal !!!! force commit used ?

Any clue... Thanks

# k8s.io/apiserver/pkg/cel/library
C:\Users\YannS\go\pkg\mod\k8s.io\apiserver@v0.28.1\pkg\cel\library\authz.go:581:19: undefined: types.TypeValue
C:\Users\YannS\go\pkg\mod\k8s.io\apiserver@v0.28.1\pkg\cel\library\cost.go:104:24: elNode.Type().GetPrimitive undefined (type *"github.com/google/cel-go/common/types".Type has no field or method GetPrimitive)
C:\Users\YannS\go\pkg\mod\k8s.io\apiserver@v0.28.1\pkg\cel\library\cost.go:144:28: args[1].Expr().GetConstExpr undefined (type "github.com/google/cel-go/common/ast".Expr has no field or method GetConstExpr)
C:\Users\YannS\go\pkg\mod\k8s.io\apiserver@v0.28.1\pkg\cel\library\cost.go:212:23: list.Type().GetListType undefined (type *"github.com/google/cel-go/common/types".Type has no field or method GetListType)
C:\Users\YannS\go\pkg\mod\k8s.io\apiserver@v0.28.1\pkg\cel\library\cost.go:220:11: cannot use &itemsNode{…} (value of type *itemsNode) as checker.AstNode value in return statement: *itemsNode does not implement checker.AstNode (wrong type for method Expr)
        have Expr() *expr.Expr
        want Expr() "github.com/google/cel-go/common/ast".Expr
C:\Users\YannS\go\pkg\mod\k8s.io\apiserver@v0.28.1\pkg\cel\library\cost.go:223:11: cannot use &itemsNode{…} (value of type *itemsNode) as checker.AstNode value in return statement: *itemsNode does not implement checker.AstNode (wrong type for method Expr)
        have Expr() *expr.Expr
        want Expr() "github.com/google/cel-go/common/ast".Expr
FAIL    github.hpe.com/cms5g/network-function-operator/core/pkg/manifest/crdHandler [build failed]

image

migounette commented 1 year ago

For my issue, cel-go v0.18.0 was proposed

replace github.com/google/cel-go => github.com/google/cel-go v0.16.0
nagius commented 1 year ago

I hit the same issue with version v0.28.2 cel-go introduced breaking changes in v0.17.0. Pinning cel-go to v0.16.1 as mentioned above solved the issue (for now).

k8s-triage-robot commented 9 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 7 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/apiserver/issues/97#issuecomment-2024972379): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.