search

kubernetes / autoscaler

Autoscaling components for Kubernetes
Apache License 2.0
8.09k stars 3.98k forks source link

Hetzner Autoscaler does not allow subnets for HCLOUD_NETWORK #5263

Closed ifeulner closed 7 months ago

ifeulner commented 2 years ago

Which component are you using?: Horizontal autoscaler

The hetzner implementation , see https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler/cloudprovider/hetzner

What version of the component are you using?: 1.25.0

Component version: 1.25.0 What k8s version are you using (kubectl version)?:

kubectl version Output
$ kubectl version

What environment is this in?:

What did you expect to happen?: If a subnet_id will be provided, the right subnet network will be used for assigning an ip when creating the autoscaler node

Autoscaler nodes get an ip out of the range specified in the subnet network What happened instead?:

Node creation fails

How to reproduce it (as minimally and precisely as possible): Specificy an subnet id in `HCLOUD_NETWORK' instead of a network id

Anything else we need to know?:

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ifeulner commented 1 year ago

/remove-lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ifeulner commented 1 year ago

/remove-lifecycle stale

apricote commented 1 year ago

Unfortunately this is not easily possible through the Hetzner Cloud API right now. Subnets do not have any IDs. You can only assign a Server to a Network, and the last created Subnet will be used, alternatively you can specify the IP yourself (in the API).

I have added 5 Votes (OP + 4 Upvotes) to the matching issue in our internal feedback tracker.

/area provider/hetzner

k8s-triage-robot commented 9 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 7 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/autoscaler/issues/5263#issuecomment-2028443618): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dominic-p commented 7 months ago

This would still be nice to have for my use case. Are there any updates on providing a subnet ID?

apricote commented 7 months ago

No updates from the API side. There is also no one working on the cluster-autoscaler side of things. We have the same feature request in the terraform provider, so perhaps its something that could be done in hcloud-go and shared between the integrations. Open for any contributions, here or in hcloud-go :)