search

kubernetes / autoscaler

Autoscaling components for Kubernetes
Apache License 2.0
8.05k stars 3.97k forks source link

`make container` target in addon-resizer makefile is running into an error #5622

Closed ShaunakJoshi1407 closed 7 months ago

ShaunakJoshi1407 commented 1 year ago

Which component are you using?: addon-resizer

What version of the component are you using?: https://github.com/kubernetes/autoscaler/tree/addon-resizer-1.8.16

What did you expect to happen?: The make container should run smoothly without running into any errors.

What happened instead?: I ran into this error: 

docker buildx inspect img-builder > /dev/null || docker buildx create --name img-builder --use
cp -r * /var/folders/d7/pr1y9kqn4z57m0j2_1xllj000000gn/T/tmp.YylFOq9v
cd /var/folders/d7/pr1y9kqn4z57m0j2_1xllj000000gn/T/tmp.YylFOq9v && sed -i 's|BASEIMAGE|gcr.io/distroless/static:latest|g' Dockerfile
sed: 1: "Dockerfile": extra characters at the end of D command
make: *** [.container-amd64] Error 1

How to reproduce it (as minimally and precisely as possible): Running make container from this branch: https://github.com/kubernetes/autoscaler/tree/addon-resizer-1.8.16 should suffice.

Anything else we need to know?: For now, I have made a minor change in this target to make this run. cd $(TEMP_DIR) && sed -i 's|BASEIMAGE|$(BASEIMAGE)|g' Dockerfile --> cd $(TEMP_DIR) && sed -i- 's|BASEIMAGE|$(BASEIMAGE)|g' Dockerfile to make it run. If this is an acceptable solution, I can make the change here.

kwiesmueller commented 1 year ago

I just tested this, on my local machine (debian) using zsh the make container command finishes as expected. Do you have more details on what's different in your proposed fix and why you think it works?

k8s-triage-robot commented 9 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 7 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/autoscaler/issues/5622#issuecomment-2016228524): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.