search

kubernetes / autoscaler

Autoscaling components for Kubernetes
Apache License 2.0
8.04k stars 3.96k forks source link

CA: Hetzner cloud-init example may need to be updated for new community packages #6106

Closed dominic-p closed 3 months ago

dominic-p commented 1 year ago

Which component are you using?: Cluster Autoscaler with Hetzner

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:

Ever since updating to the new community hosted APT repo, I've been experience network issues with my clusters. It appears that the issue has do with the KUBELET_EXTRA_ARGS env variable (see this comment). I was previously configuring this variable as shown in the example cloud-init script here.

Describe the solution you'd like.:

I'm not exactly sure why the CA needs this env variable set for Hetzner. In my testing, it didn't seem to be affected like the CCM was. But, I thought I would bring up the potential issue anyway.

I'm currently working around the problem by overwriting the new file that the deb package introduces, but that's not exactly the most elegant solution.

apricote commented 12 months ago

I'm not exactly sure why the CA needs this env variable set for Hetzner. In my testing, it didn't seem to be affected like the CCM was. But, I thought I would bring up the potential issue anyway.

I dont think this variable is specifically required for cluster-autoscaler, more that it makes sense to always deploy hcloud-cloud-controller-manager in tandem with CA.

The cloud-init example is really outdated, if anyone wants to update it I am more than happy to review/help.

apricote commented 12 months ago

/area provider/hetzner

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

dominic-p commented 8 months ago

I don't think this one is stale. I haven't had a chance to look into updating the example cloud-init myself, but it would be helpful for future users.

apricote commented 8 months ago

/remove-lifecycle stale

If anyone wants to work on this, we made these changes to the hcloud-cloud-controller-manager documentation regarding KUBELET_EXTRA_ARGS: https://github.com/hetznercloud/hcloud-cloud-controller-manager/pull/607/files

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

dominic-p commented 5 months ago

Unfortunately, I haven't had a chance to update the docs on this yet, but I still don't think it's stale.

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

dominic-p commented 4 months ago

I still think a doc update might be appropriate here, but I haven't had a chance to tackle it myself.

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 3 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes/autoscaler/issues/6106#issuecomment-2211385282): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.