search

kubernetes / autoscaler

Autoscaling components for Kubernetes
Apache License 2.0
7.99k stars 3.94k forks source link

Cluster-autoscaler for CAPI create status configmap in the workload cluster #6150

Open jonathanbeber opened 1 year ago

jonathanbeber commented 1 year ago

Which component are you using?: cluster-autoscaler for Cluster API.

What version of the component are you using?:

Component version: v1.27.2

What k8s version are you using (kubectl version)?:

v1.27.4

What environment is this in?: AWS managed by CAPA.

What did you expect to happen?:

The status configmap should be created in the cluster using the client resulted from the --cloud-config parameter.

What happened instead?:

The status configmap is created in the workload cluster.

How to reproduce it (as minimally and precisely as possible):

Deploy cluster-autoscaler with a topology as Autoscaler running in management cluster using service account credentials, with separate workload cluster and check that the status configmap is created in the workload cluster.

Anything else we need to know?:

I would like to work in this task.

jonathanbeber commented 1 year ago

The client used to write the configmap seems to come from https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/main.go#L392, set in line https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/main.go#L457 for AutoscalerOptions. That being said, as --cloud-config is not kubernetes client for other cloud providers, I believe there's no way for these change be just in the ClusterAPI provider.

elmiko commented 9 months ago

thanks for reporting this, it sounds like this might be really difficult to fix from the capi provider.

perhaps we should start with a docs update so that users know the configmap will be created in the cluster specified by the --kubeconfig parameter?

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

elmiko commented 6 months ago

i think we still need to deal with somehow

/remove-lifecycle stale

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

elmiko commented 3 months ago

this needs fixing

/remove-lifecycle stale

/help-wanted

elmiko commented 3 months ago

/help

k8s-ci-robot commented 3 months ago

@elmiko: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes/autoscaler/issues/6150): >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
Shubham82 commented 3 months ago

/triage accepted /lifecycle frozen