kubernetes / autoscaler

Autoscaling components for Kubernetes
Apache License 2.0
8.08k stars 3.97k forks source link

helm template: "warning: cannot overwrite table with non table for cluster-autoscaler.serviceMonitor.metricRelabelings (map[])" #6357

Open nobu-k opened 11 months ago

nobu-k commented 11 months ago

Which component are you using?:

cluster-autoscaler-chart

What version of the component are you using?:

9.28.0-9.34.0

Component version:

What k8s version are you using (kubectl version)?:

kubectl version Output
$ kubectl version

WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.8", GitCommit:"395f0a2fdc940aeb9ab88849e8fa4321decbf6e1", GitTreeState:"clean", BuildDate:"2023-08-24T00:50:44Z", GoVersion:"go1.20.7", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"26+", GitVersion:"v1.26.10-eks-4f4795d", GitCommit:"164dfb62db432c0b28a1fced3956256af68533b6", GitTreeState:"clean", BuildDate:"2023-10-20T23:21:27Z", GoVersion:"go1.20.10", Compiler:"gc", Platform:"linux/amd64"}

What environment is this in?:

It's about Helm chart.

What did you expect to happen?:

serviceMonitor.metricRelabelings in values.yaml can be configured without warning.

What happened instead?:

helm template generates the following warning.

coalesce.go:220: warning: cannot overwrite table with non table for cluster-autoscaler.serviceMonitor.metricRelabelings (map[])

How to reproduce it (as minimally and precisely as possible):

Add an item to serviceMonitor.metricRelabelings in values.yaml and run helm template with it.

Anything else we need to know?:

The current default value of serviceMonitor.metricRelabelings is now {} but it should probably be []?

Shubham82 commented 11 months ago

cc @gjtempleton

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Shubham82 commented 8 months ago

/remove-lifecycle stale

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Shubham82 commented 4 months ago

/remove-lifecycle stale

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Shubham82 commented 1 month ago

/remove-lifecycle stale